Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Commit Signing: Unable to open allowed keys file #9732

Open
MartinLoeper opened this issue Apr 1, 2024 · 0 comments
Open

Git Commit Signing: Unable to open allowed keys file #9732

MartinLoeper opened this issue Apr 1, 2024 · 0 comments
Assignees
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality
Milestone

Comments

@MartinLoeper
Copy link

  • VSCode Version: 1.87.2

  • Local OS Version: NixOS Unstable

  • Remote OS Version: NixOS Unstable

  • Remote Extension/Connection Type: Containers

  • Logs:

Good "git" signature with ECDSA-SK key SHA256:<redacted>
Unable to open allowed keys file "/home/node/.ssh/allowed_signers": No such file or directory
sig_find_principals: sshsig_get_principal: No such file or directory
No principal matched.

Steps to Reproduce:

  1. create a signed commit in a git repo and configure allowed signers:
[gpg "ssh"]
  allowedsignersfile = "~/.ssh/allowed_signers"
  1. open the repo using devcontainers extension

Does this issue occur when you try this locally?: No
Does this issue occur when you try this locally and all extensions are disabled?: No

It looks like the allowed_signers file is simply not copied over into the container. Can we make provide a devcontainer.json attribute or so to copy files which are required for git commit signing to work properly.

Possibly related to:

What is interesting though: Signing works as expected. It is only validation which looks like it's not supported yet.

@VSCodeTriageBot VSCodeTriageBot added the containers Issue in vscode-remote containers label Apr 1, 2024
@chrmarti chrmarti added the feature-request Request for new features or functionality label Apr 2, 2024
@chrmarti chrmarti added this to the Backlog milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants