Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt quick pick item guidance in Remote Repositories #281

Closed
joyceerhl opened this issue Dec 12, 2022 · 4 comments
Closed

Adopt quick pick item guidance in Remote Repositories #281

joyceerhl opened this issue Dec 12, 2022 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality polish verified Verification succeeded
Milestone

Comments

@joyceerhl
Copy link
Contributor

We now have team wide quick pick item guidance microsoft/vscode#158895

We should adopt this guidance in Remote Repositories' pickers.

Originally reported by @jrieken

  • be on vscode.dev
  • pick a branch form the status bar picker
  • picker has a title and that's something we usually don't do, e.g desktop/file doesn't

Screen Shot 2021-06-03 at 09 58 38

Screen Shot 2021-06-03 at 10 27 07

@joyceerhl joyceerhl added feature-request Request for new features or functionality polish labels Dec 12, 2022
@joyceerhl joyceerhl added this to the December 2022 milestone Dec 12, 2022
@joyceerhl joyceerhl self-assigned this Dec 12, 2022
@joyceerhl joyceerhl modified the milestones: December 2022, January 2023 Dec 14, 2022
@joyceerhl joyceerhl added the verification-needed Verification of issue is requested label Jan 23, 2023
@eleanorjboyd eleanorjboyd added the verified Verification succeeded label Jan 25, 2023
@eleanorjboyd
Copy link
Member

is there anything extra I need in order to get the new version of vscode.dev? Currently, it seems my quick picker still has a title
Screenshot 2023-01-25 at 8 16 06 AM

@eleanorjboyd eleanorjboyd added verification-steps-needed Steps to verify are needed for verification and removed verified Verification succeeded labels Jan 25, 2023
@joyceerhl
Copy link
Contributor Author

Are you using insiders.vscode.dev or vscode.dev?

@joyceerhl joyceerhl removed the verification-steps-needed Steps to verify are needed for verification label Jan 25, 2023
@eleanorjboyd
Copy link
Member

hm I was actually on github.dev- I should be using insider.vscode.dev?

@joyceerhl
Copy link
Contributor Author

Yes, please use insiders.vscode.dev as that ships both latest VS Code Insiders and latest RemoteHub. github.dev only ships stable RemoteHub regardless of VS Code quality, so should not be used for VS Code verification

@bhavyaus bhavyaus added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality polish verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants