Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to open files with special characters in the file name #97

Closed
slavek-kucera opened this issue Sep 4, 2023 · 2 comments 路 Fixed by #98
Closed

Unable to open files with special characters in the file name #97

slavek-kucera opened this issue Sep 4, 2023 · 2 comments 路 Fixed by #98
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@slavek-kucera
Copy link

I am unable to open files that have special characters in their file name (like !#$%&'()+,-.0123456789;=@ABCDEFGHIJKLMNOPQRSTUVWXYZ[]^_`abcdefghijklmnopqrstuvwxyz{}~ or test_utf_8_馃Э) that I use during testing.
I think that the problem is that URIs are not properly encoded and then decoded in places like

const url = serverUri.with({ query: 'stat' }).toString(/*skipEncoding*/ true);

and
const p = path.join(folderMountPath, ctx.path.substring(mountPrefix.length));

image

@aeschli
Copy link
Contributor

aeschli commented Sep 29, 2023

To verify:

  • close this repo
  • run yarn && yarn sample
  • this opens vscode in the browser on a test workspace that has folders and files with special characters,
  • verify these can be opened.

@aeschli aeschli self-assigned this Sep 29, 2023
@aeschli aeschli added this to the September 2023 milestone Sep 29, 2023
@slavek-kucera
Copy link
Author

馃憤 The fix solves the problem. Thank you.

@aeschli aeschli added verified Verification succeeded bug Issue identified by VS Code Team member as probable bug labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants