Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Refresh tree view arrangement #96

Closed
philliphoff opened this issue Jun 16, 2021 · 3 comments · Fixed by #128
Closed

Refresh tree view arrangement #96

philliphoff opened this issue Jun 16, 2021 · 3 comments · Fixed by #128
Assignees
Labels
enhancement Changes to existing features P2
Projects

Comments

@philliphoff
Copy link
Contributor

We'd like to revisit how different kinds of nodes show up in the tree view and where (e.g. de-emphasize the Dapr and other supporting services in favor of emphasizing the user's own services).

@philliphoff philliphoff changed the title Refresh tree view arrangment Refresh tree view arrangement Jun 16, 2021
@dbreshears dbreshears added this to To Do in 0.3.0 Jun 16, 2021
@philliphoff philliphoff added the enhancement Changes to existing features label Jun 16, 2021
@dbreshears dbreshears added the P2 label Jul 14, 2021
@philliphoff philliphoff moved this from To Do to In Progress in 0.3.0 Jul 19, 2021
@philliphoff
Copy link
Contributor Author

@BigMorty What do you think about this arrangement?

  • Dashboard moved from being its own node to just an inline command on the application node.
  • Project services (i.e. those declared by the user in the tye.yaml) listed directly beneath the application node.
  • Non-project services (i.e. those implicitly created by Tye host or its extensions) listed beneath an Other Services node (and collapsed by default).
  • Other Service node has no icon to better separate the two classes of nodes.

Note that there are changes needed on the Tye CLI side to fully support this model. For example, the redis and zipkin nodes should be "project services" as they're listed in tye.yaml but as external; there's not enough information in the service metadata for us to make that distinction, however.

Another question is where the ingress node should go; as it (and there can actually be more than one) can be the main entrypoint for an application, should it be more upfront?

Screenshot 2021-07-19 at 13 48 07

@philliphoff
Copy link
Contributor Author

@BigMorty Here's another iteration, after sketching a Tye CLI change to provide additional metadata about the "source" of a service (i.e. the configuration file, an extension, or the host). I've also updated the icons to try to better represent services (e.g. server processes, external components, ingress, etc.).

Note I'm now using the same icon both for services and their replicas. I think that's ok, actually, but let me know what you think.

Screenshot 2021-07-19 at 16 14 10

@BigMorty
Copy link
Member

This looks great, ship it! 😀

@philliphoff philliphoff self-assigned this Jul 20, 2021
0.3.0 automation moved this from In Progress to Done Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Changes to existing features P2
Projects
No open projects
0.3.0
Done
Development

Successfully merging a pull request may close this issue.

3 participants