Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-styled-components extension's css intellisense is not working after updating to latest version #61

Closed
booooora opened this issue Nov 21, 2022 · 4 comments

Comments

@booooora
Copy link

booooora commented Nov 21, 2022

Hi, I'm using JavaScript and TypeScript Nightly with vscode-styled-components extension.
But after updating JavaScript and TypeScript Nightly to latest version, vscode-styled-components extension's css intellisense (suggestion) is not working.
When I uninstall or downgrade JavaScript and TypeScript Nightly to v5.0.20221103, vscode-styled-components css suggestion is working as expected.

JavaScript and TypeScript Nightly v5.0.202211170 -> css suggestion not working
(downgrading to v5.0.20221113 is also not working)
image

JavaScript and TypeScript Nightly v5.0.20221103 -> css suggestion working
image

Extension version: v5.0.202211170
VS Code version: Code 1.73.1 (Universal)
OS version: macOS Ventura
vscode-styled-components extension version: v1.7.5

@ricardroberg

This comment was marked as spam.

@mjbvz
Copy link
Contributor

mjbvz commented Nov 28, 2022

Please file this against the styled components extension. It likely needs to be updated to support TS 5+

@jasonwilliams
Copy link

jasonwilliams commented Dec 1, 2022

Thank you @booooora for raising this detailed issue. I have spent some time on this and it does seem to be on the typescript side.

Please file this against the styled components extension. It likely needs to be updated to support TS 5+

Our extension does use the latest version of typescript (4.9.3) and I have tested it with "next" (5.x) and it still happens so I don't think this is the case.
I have published a pre-relasee version of the extension, so you can try that here but I can see it still doesn't work.

I have forked the typescript plugin and published it from here:
https://github.com/styled-components/typescript-styled-plugin

Version 20221103 successfully calls into the language server and receives completions
working-20221103

Version 20221108 fails to call into the language server, so we don't get anything at all.
notworking

@mjbvz can we reopen this or do you have any more detail on this issue? Looks like there's a change somewhere which broke the language server.

@mjbvz
Copy link
Contributor

mjbvz commented Dec 1, 2022

@jasonwilliams Can you please open an issue against TypeScript for this? They may have some idea of what changed in 5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants