-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension tags seem to be calculated incorrectly which blocks publishing #569
Comments
I have the same issue, 5 keywords and 39 automatic tags => no way to publish |
We are running into this issue with Calva, mentioned in the discussion linked by @serbani. It's a bit ironic, because as a result of that announcement I deleted three of the keywords specified in the manifest, from 10 to 7... I think that a limitation like this must be on something very predictable by the extension author. For instance, it shouldn't be on the tags displayed on the marketplace page for the extension, because extension authors only partly have control over those. |
For the time being I've manually edited the |
Sorry about that. The marketplace team has introduced a tag limit, and we are working with them to lift this boundary - as there are internal tags that VS Code adds. Thank you for your understanding. |
Looks like the edge case is missed on this. Upload pipeline is counting automatic tags too. |
We turned off the tag validation for now. We apologies for breaking your workflow. |
Thanks for removing the blocker for now, @prashantvc! ❤️ I could publish now, without editing the VSIX. 🚀
Can you make it so that you only restrict
Is the restriction max 10 or max 9? |
Yup, we will restrict only keywords.
The restriction will be max 10, sorry for the confusion :) |
We found that confusing as well. In the documentation it says Another thing that concerns me about that new rule, is what happens to extensions with lots of ecosystem support? I get that it is bad to spam the tags, but we are adding more functionality (and languages) to our Symflower plugin every month. Any advice on how to tag in the future? |
I think this is a case of the VS Code Marketplace becoming more restrictive because up until today, there was no issue publishing with the following metadata. However, the metadata is generated by vsce.
Given an extension with the following keywords (clearly less than 10) : https://github.com/redhat-developer/vscode-quarkus/blob/ee500685a159eeed8605c2b8ffe794ec19670102/package.json#L27-L32
When publishing, I'll see :
ERROR You exceeded the number of allowed tags of 10.
(as described at https://code.visualstudio.com/api/working-with-extensions/publishing-extension#i-get-a-you-exceeded-the-number-of-allowed-tags-of-10-error-when-i-try-to-publish-my-extension )
Looking into the
extension.vsixmanifest
that's packaged into the vsix, I see :That's definitely more than 10. The
__ext_*
terms probably shouldn't be there, but there's keywords in there that come from other features like https://code.visualstudio.com/api/references/contribution-points#contributes.languages (id
,alias
). I compared with a previous vsix (prior to today) that did publish successfully and the same terms existed.The text was updated successfully, but these errors were encountered: