Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support package.json repository.directory field #980

Open
Philipp15b opened this issue May 20, 2024 · 0 comments
Open

Support package.json repository.directory field #980

Philipp15b opened this issue May 20, 2024 · 0 comments
Assignees
@benibenj
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities

Comments

@Philipp15b
Copy link

When guessing the baseUrls (see guessBaseUrls function), vscode-vsce does not seem to respect the optional directory field in the package.json. It allows specifying a subdirectory in which the extension lives. I expected that the base urls are guessed with respect to that directory. Thanks!
@benibenj benibenj self-assigned this May 20, 2024
@benibenj benibenj added feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities labels May 20, 2024
@ChaseKnowlden ChaseKnowlden mentioned this issue May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benibenj benibenj

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a directory field to open the README in a different directory ChaseKnowlden/vscode-vsce
2 participants
@Philipp15b @benibenj