Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Design Tokens For Remaining Component Magic Values #121

Closed
hawkticehurst opened this issue Jun 4, 2021 · 0 comments · Fixed by #160
Closed

Create Design Tokens For Remaining Component Magic Values #121

hawkticehurst opened this issue Jun 4, 2021 · 0 comments · Fixed by #160
Assignees
@hawkticehurst
Labels
enhancement New feature or request
Milestone
Private Beta

Comments

@hawkticehurst
Copy link
Member

Feature/component description

Currently, a number of component styles are still implemented with magic values which should be refactored into design tokens––especially color tokens that need to be associated with the correct VS Code theme color CSS variables.

Use case

This work is required to meet the June 2021 iteration plan goal of fully configuring component theming.
@hawkticehurst hawkticehurst added the enhancement New feature or request label Jun 4, 2021
@hawkticehurst hawkticehurst self-assigned this Jun 4, 2021
@hawkticehurst hawkticehurst added bug Something isn't working and removed bug Something isn't working labels Jun 4, 2021
@hawkticehurst hawkticehurst mentioned this issue Jun 4, 2021
Closed
34 tasks
@hawkticehurst hawkticehurst added this to the Private Beta milestone Jun 4, 2021
This was referenced Jun 9, 2021
Merged
Merged
Merged
Merged
This was referenced Jun 17, 2021
Merged
Merged
Merged
This was referenced Jun 24, 2021
Merged
Merged
Merged
Merged
@hawkticehurst hawkticehurst mentioned this issue Jul 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hawkticehurst hawkticehurst

Labels
enhancement New feature or request
Projects
None yet
Milestone
Private Beta
Development

Successfully merging a pull request may close this issue.

Update VS Code Data Grid Design Tokens
1 participant
@hawkticehurst