Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox Does Not Collapse When Clicked #131

Closed
hawkticehurst opened this issue Jun 7, 2021 · 2 comments
Closed

Combobox Does Not Collapse When Clicked #131

hawkticehurst opened this issue Jun 7, 2021 · 2 comments
Assignees
Labels
bug Something isn't working question Further information is requested
Milestone

Comments

@hawkticehurst
Copy link
Member

hawkticehurst commented Jun 7, 2021

Describe the bug

Not completely sure if this should be categorized as a bug or not, but the default behavior shipped by the FAST Combobox is that a user can click the topbar element to expand it but cannot click the topbar element to collapse it. The only way to collapse a Combobox is to click outside of its bounding area.

FAST Example
Toolkit Example

This runs in contrast to the Dropdown (FAST Select) which can be expanded and collapsed by clicking the topbar element.

FAST Example
Toolkit Example

To reproduce

Steps to reproduce the behavior:

  1. Create a vscode-combobox
  2. Click the element to open
  3. Try to click the element again (it will not collapse)

Expected behavior

My expectation is that the behaviors of the Combobox and Dropdown should be aligned. Or at the very minimum clicking the Combobox chevron should collapse the Combobox.

Additional context

@daviddossett Your feedback on this would be helpful because I'm not sure what the common behaviors for a Combobox are (i.e. maybe this is a common UX convention for Comboboxes?).

@hawkticehurst hawkticehurst added the bug Something isn't working label Jun 7, 2021
@daviddossett
Copy link
Collaborator

Great catch!

@daviddossett daviddossett self-assigned this Jun 7, 2021
@daviddossett daviddossett added this to the Public Beta milestone Jun 21, 2021
@daviddossett daviddossett added the question Further information is requested label Jun 21, 2021
@hawkticehurst
Copy link
Member Author

Closing since comboboxes have been removed from the toolkit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants