Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y_VscodeWebviewUiToolkit_AllComponents_Buttons_DevTools: The "with icon only" button has no name property assigned #179

Closed
Shivamd1 opened this issue Aug 23, 2021 · 3 comments · Fixed by #214
Assignees
Labels
accessibility There's an accessibility issue bug Something isn't working
Milestone

Comments

@Shivamd1
Copy link

Shivamd1 commented Aug 23, 2021

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHubTags: #A11yMAS;#A11yTCS;#A11ySev2;#SH_VscodeWebviewUiToolkit_Aug2021;#Webview UI Toolkit for Visual Studio Code;#Win32;#FTP;#DesktopApp;#WCAG4.1.2;#AINotInScope;#DevTools;

Environment Details:

Application Name: Vscode Webview Ui Toolkit
Windows Version: Win10

Repro Steps:

  1. Launch VS Code
  2. Open WebView UI Toolkit: All Component extension
  3. Tab to Button and tab to "with icon only" button , open developer tool (ctrl+shift+i) check if name is provided to it.

Actual:

The "with icon only" button has no name property assigned.

Expected:

The "with icon only" button should have name property assigned like for eg. here "with icon only" can be given as a name.

User Impact:

Screen reader users will not get the proper information about the button.

@Shivamd1 Shivamd1 added the bug Something isn't working label Aug 23, 2021
@hawkticehurst hawkticehurst added the accessibility There's an accessibility issue label Aug 30, 2021
@hawkticehurst hawkticehurst added this to the Public Beta milestone Sep 16, 2021
@hawkticehurst
Copy link
Member

@Shivamd1 I've sent an updated build with a fix for this issue!

@Shivamd1
Copy link
Author

Shivamd1 commented Oct 5, 2021

verified the issue and it not reproduces closing the bug

@Shivamd1 Shivamd1 closed this as completed Oct 5, 2021
@fsteffi
Copy link

fsteffi commented Feb 2, 2023

GithubTags:#Closed;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility There's an accessibility issue bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants