editor.find.seedSearchStringFromSelection no longer honored after 1.45 update

[reporter123]

Issue Type: Bug

Setting editor.find.seedSearchStringFromSelection=true no longer has any effect.

Steps to Reproduce:

1. Set editor.find.seedSearchStringFromSelection = true
2. Select text
3. Open "Search" side ber

Search field is no long filled out with the selection.

VS Code version: Code 1.46.0 (a5d1cc2, 2020-06-10T08:59:04.923Z)
OS version: Linux x64 5.4.0-33-generic

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-3537U CPU @ 2.00GHz (4 x 1829)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: disabled_software skia_renderer: disabled_off_ok video_decode: unavailable_off viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	1, 2, 1
Memory (System)	5.68GB (0.21GB free)
Process Argv	--no-sandbox --unity-launch
Screen Reader	no
VM	0%
DESKTOP_SESSION	plasma
XDG_CURRENT_DESKTOP	KDE
XDG_SESSION_DESKTOP	KDE
XDG_SESSION_TYPE	x11

Extensions: none

[JacksonKearl]

This is by design, focusing the viewlet (which is what clicking on it does) shouldn't affect its contents. Discussion here: #91901

You can use the Search: Find in Files command (Ctrl/Cmd + Shift + F) to seed&focus, or set "search.seedOnFocus": true.