New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make POSIX-compliant to increase portability and remove bash
depend…
#100145
Conversation
…ency on Linux. Fix causes of `shellcheck` warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the VS Code on lines 8 and 33 be replaced with @@PRODNAME@@?
Does this fix an actual issue? |
I'm unable to start VS Code on my system which doesn't have |
Can you give me an example of said system? I'm just looking for a specific practical example. |
Sure thing. There are certain Linux distributions that don't enforce the usage of, and don't come pre-packaged with |
I'm actually surprised VS Code runs in said systems. 👌 |
Co-authored-by: VoidNoire <18732253+VoidNoire@users.noreply.github.com>
Co-authored-by: VoidNoire <18732253+VoidNoire@users.noreply.github.com>
…ency on Linux. Fix causes of
shellcheck
warnings.This PR fixes #100144 by removing bashisms and replacing them with POSIX-compliant alternatives.