Explorer: each click results in 2 open editor calls

[bpasero]

I tried to debug this for 1h and could not get to the bottom of it. I suspect that the same listener is created twice, but could not verify that.

Anyhow, steps:

• add a console.log('onDidOpenResource', new Error().stack); to

  vscode/src/vs/workbench/contrib/files/browser/views/explorerView.ts

  Line 428 in 18cb88e

  const selection = this.tree.getSelection();

• click on a file

=> 🐛 the listener is called twice and as such we try to open editors 2 times

[joaomoreno]

Let me see what I find out.

[bpasero]

i hope this is not some weird debug issue, I would not trust the devtools on this one, listeners are weird...

[joaomoreno]

Comes from these two:

vscode/src/vs/base/browser/ui/list/listWidget.ts

Lines 634 to 637 in da8f44c

	this.list.setSelection([focus], e.browserEvent);
	if (this.openController.shouldOpen(e.browserEvent)) {
	this.list.open([focus], e.browserEvent);

We gotta kill that open controller.

[joaomoreno]

Notes to self:

• make sure this doesn't break: Cannot configure build tasks by clicking on the suggested bar (after trying to execute a task) #58124
• make sure pinning still works in:
  • SCM view
  • extension views
• make sure opening works in:
  • breakpoints view
  • open editors view
  • outline pane
  • references tree
• make sure middle click works in:
  • open editors
  • breakpoints view
• make sure double click works in:
  • breakpoints view
• revisit openOnSelection and openOnFocus options
• commentsView.ts doesn't have an accessibility provider
• folders can be expanded with both settings

[isidorn]

@joaomoreno I see you area already on this. Let me know how I can help. Otherwise once the PR is ready I can make sure all the views are still working as expected: open editors, explorer, debug views.