Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion Widget appears to eagerly #1003

Closed
jseanxu opened this issue Dec 4, 2015 · 8 comments
Closed

Suggestion Widget appears to eagerly #1003

jseanxu opened this issue Dec 4, 2015 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@jseanxu
Copy link

jseanxu commented Dec 4, 2015

I have custom key bindings like these

{ "key": ";",  "command": "^acceptSelectedSuggestion", "when": "editorTextFocus && suggestWidgetVisible" },
{ "key": "space",  "command": "^acceptSelectedSuggestion", "when": "editorTextFocus && suggestWidgetVisible" },
...

to mimic how autocomplete works in the full VS, however, this makes typing something like

var foo = 1;

difficult in JavaScript/TypeScript because when typing 1, the suggestion widget eagerly appears with Int16Array and hitting ; autcompletes to it and you end up with

var foo = Int16Array;
@joaomoreno
Copy link
Member

Numbers seem to be words...

@egamma
Copy link
Member

egamma commented Dec 4, 2015

@jrieken for this scenario it would make sense when 7x24 intellisense only pops-up when there is a prefix match.

@jrieken
Copy link
Member

jrieken commented Dec 4, 2015

Yes, if would be even more strict and say the current word never matching anything if its just numbers

@jseanxu
Copy link
Author

jseanxu commented Dec 5, 2015

Can we get a config hook to make it only prefix match?

@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Dec 7, 2015
@dbaeumer
Copy link
Member

dbaeumer commented Dec 8, 2015

There is not to much I can do in TS land since the tsserver gets ask for code completion and provides the proper items. @joaomoreno I assign to you since it is more a code complete request issue.

@joaomoreno
Copy link
Member

@jrieken this is the one we were just talking about

@jrieken
Copy link
Member

jrieken commented Dec 9, 2015

yeah, related to #752

@joaomoreno joaomoreno removed this from the Dec 2015 milestone Dec 9, 2015
@egamma egamma modified the milestone: Backlog Dec 10, 2015
@egamma egamma added the important Issue identified as high-priority label Dec 15, 2015
@jrieken jrieken modified the milestones: Backlog, Dec 2015 Dec 15, 2015
@jrieken jrieken assigned jrieken and unassigned joaomoreno Dec 15, 2015
@jrieken
Copy link
Member

jrieken commented Dec 15, 2015

Until we improve the API we don't automatically show suggestion when the current word is just a number.

@jrieken jrieken assigned joaomoreno and unassigned jrieken Dec 15, 2015
@joaomoreno joaomoreno added the verified Verification succeeded label Dec 16, 2015
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants