Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for setInput cancellation #100456

Closed
bpasero opened this issue Jun 18, 2020 · 0 comments
Closed

Check for setInput cancellation #100456

bpasero opened this issue Jun 18, 2020 · 0 comments
Assignees
@JacksonKearl
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders search-editor
Milestone
July 2020

Comments

@bpasero
Copy link
Member

bpasero commented Jun 18, 2020

The CancellationToken for setInput should be checked on after every awaited operation to see if the opening was cancelled. This can happen if the user quickly clicks through editors.
@bpasero bpasero added debt Code quality issues search-editor labels Jun 18, 2020
@JacksonKearl JacksonKearl added this to the July 2020 milestone Jul 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders search-editor
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
3 participants
@bpasero @JacksonKearl and others