Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

References: clicking on result moves focus into editor #100726

Closed
bpasero opened this issue Jun 22, 2020 · 4 comments
Closed

References: clicking on result moves focus into editor #100726

bpasero opened this issue Jun 22, 2020 · 4 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders references-viewlet verified Verification succeeded
Milestone
June 2020

Comments

@bpasero
Copy link
Member

bpasero commented Jun 22, 2020 •
edited
Loading

Steps to Reproduce:

  1. run a reference search
  2. click on a result

=> 馃悰 focus moves into the editor
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Jun 22, 2020
@joaomoreno
Copy link
Member

joaomoreno commented Jun 22, 2020 •
edited
Loading

I can't reproduce. 馃 Can you repro with a fresh setting base?

For me, focus only moves to the editor if I double click.

@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Jun 22, 2020
@joaomoreno joaomoreno added this to the June 2020 milestone Jun 22, 2020
@joaomoreno joaomoreno removed bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Jun 22, 2020
@bpasero
Copy link
Member Author

bpasero commented Jun 22, 2020

Very likely already fixed, cannot reproduce running from master

@bpasero bpasero changed the title Search: clicking on result moves focus into editor References: clicking on result moves focus into editor Jun 22, 2020
@bpasero
Copy link
Member Author

bpasero commented Jun 22, 2020

Ah, it is the references view that has this behaviour, not the search.

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Jun 22, 2020
@jrieken
Copy link
Member

jrieken commented Jun 22, 2020

Likely caused by microsoft/vscode-references-view#62

@jrieken jrieken mentioned this issue Jun 22, 2020
Merged
1 task
@bpasero bpasero added the verified Verification succeeded label Jun 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders references-viewlet verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
5 participants
@joaomoreno @roblourens @bpasero @jrieken and others