use shared webpack config for browser #101066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamodio
suggested changes
Jun 25, 2020
| }); | ||
| config.plugins.push(new webpack.DefinePlugin({ WEBWORKER: JSON.stringify(true) })) |
There was a problem hiding this comment.
@aeschli I think we should move this into the shared file -- so that if others need to have conditional code for node vs webworkers it is standardized.
|
I'll move it to the shared config, but we also want to add API to vscode.d.ts for extensions to detect that they are running on a browser extension host. |
|
Yeah that makes sense for runtime checks, the WEBWORKER var is for conditional webpack bundling checks. |
|
oh, cool, didn't know that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the shared webpack config for browser