Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook: looses contents when moving down #101378

Closed
bpasero opened this issue Jun 30, 2020 · 1 comment
Closed

Notebook: looses contents when moving down #101378

bpasero opened this issue Jun 30, 2020 · 1 comment
Assignees
@rebornix @jrieken
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone
June 2020

Comments

@bpasero
Copy link
Member

bpasero commented Jun 30, 2020

Testing #100965

  • have 3 notebooks (2 inactive tabs, 1 active)
  • move the active one down

=> contents are not restored
=> there are errors in the console

recording (7)
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Jun 30, 2020
@jrieken jrieken added this to the June 2020 milestone Jun 30, 2020
@jrieken jrieken added the important Issue identified as high-priority label Jun 30, 2020
@bpasero bpasero mentioned this issue Jun 30, 2020
Closed
2 tasks
@rebornix rebornix self-assigned this Jun 30, 2020
@jrieken
Copy link
Member

jrieken commented Jun 30, 2020 •
edited

This is fishy... The widget gets disposed, not re-used because this is considered to be an open-sequence, so _disposeWidget is being called. Then a new widget is created (which is fine) but for some reason the models don't get resolved again but somehow re-used...

@bpasero bpasero added the verified Verification succeeded label Jul 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
4 participants
@rebornix @bpasero @jrieken and others