Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick open: Include symbols should not block the search based on filename #101487

Open
Jack-Works opened this issue Jul 1, 2020 · 5 comments
Open
Assignees
Labels
feature-request Request for new features or functionality quick-open Quick-open issues (search, commands) workspace-symbols
Milestone

Comments

@Jack-Works
Copy link
Contributor

Version: 1.47.0-insider (user setup)
Commit: b9d7ec9
Date: 2020-06-20T00:08:33.687Z
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

Steps to Reproduce:

  1. Open "search.quickOpen.includeSymbols"
  2. Search(Ctrl+P) in a big project (for example, typescript) by filename
  3. Expected: filename comes first, then the slow symbol search joins the result later.
  4. Actual: The symbol search blocks the filename search and no results appear in a long time.

Does this issue occur when all extensions are disabled?: Yes

@bpasero bpasero changed the title Quick open: Include symbols blocks the search based on filename Quick open: Include symbols should not block the search based on filename Jul 1, 2020
@bpasero
Copy link
Member

bpasero commented Jul 1, 2020

Related #91445

Showing symbols after files might not be an ideal solution though.

@bpasero bpasero added feature-request Request for new features or functionality quick-pick Quick-pick widget issues workspace-symbols labels Jul 1, 2020
@Jack-Works
Copy link
Contributor Author

Related #91445

Showing symbols after files might not be an ideal solution though.

Hi I didn't mean the order of the search results. I mean the search providers can "gradually" add their results into the result list and don't have to wait all provider finish it's searching.

@bpasero
Copy link
Member

bpasero commented Jul 1, 2020

Yeah understood, but that might be a frustrating experience if the user started to go through the list of files and then suddenly more results are intermixed.

@bpasero bpasero added quick-open Quick-open issues (search, commands) and removed quick-pick Quick-pick widget issues labels Apr 7, 2021
@TylerLeonhardt TylerLeonhardt self-assigned this Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality quick-open Quick-open issues (search, commands) workspace-symbols
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @TylerLeonhardt @Jack-Works and others