Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut & Copy does not work on iPad OS #101564

Closed
daybrush opened this issue Jul 2, 2020 · 9 comments · Fixed by #101702
Closed

Cut & Copy does not work on iPad OS #101564

daybrush opened this issue Jul 2, 2020 · 9 comments · Fixed by #101702
Assignees
Labels
feature-request Request for new features or functionality ios-ipados verification-needed Verification of issue is requested verified Verification succeeded web Issues related to running VSCode in the web
Milestone

Comments

@daybrush
Copy link
Contributor

daybrush commented Jul 2, 2020

  • VSCode Version: 1.45.1
  • OS Version: iPad 13.5

Steps to Reproduce:

I found in this part that forcibly returned empty.

getScreenReaderContent: (currentState: TextAreaState): TextAreaState => {
if (browser.isIPad) {
// Do not place anything in the textarea for the iPad
return TextAreaState.EMPTY;
}

Is there a reason? If I remove this part, it works fine.

The currentState contains the selection range and cursor position.

TextAreaState is forcibly empty, so the textarea value and selection range cannot be updated.

@daybrush daybrush changed the title Cut & Copy does not work on ipad. Cut & Copy does not work on iPad OS 13.5 Jul 2, 2020
@daybrush daybrush changed the title Cut & Copy does not work on iPad OS 13.5 Cut & Copy does not work on iPad OS Jul 2, 2020
@alexdima alexdima added feature-request Request for new features or functionality web Issues related to running VSCode in the web ios-ipados labels Jul 2, 2020
@bpasero bpasero modified the milestones: Backlog, July 2020 Aug 17, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2020
@TylerLeonhardt
Copy link
Member

I tried this in Codespaces (insiders) and I just can't get it to work.

  • No keybindings work (Cmd + C/V or Ctrl + C/V)
  • The Edit -> Copy menu item doesn't seem to copy (I pasted using the paste button in the keyboard and it didn't paste what I copied)

I'm fairly new to iPad but I figured at least one of these methods would have worked so I'm reopening.

@TylerLeonhardt TylerLeonhardt reopened this Aug 2, 2021
@rzhao271 rzhao271 modified the milestones: July 2020, August 2021, Backlog Aug 2, 2021
@bpasero
Copy link
Member

bpasero commented Aug 6, 2021

@TylerLeonhardt for me it works just fine on https://vscode-web-test-playground.azurewebsites.net/?enter=true at least, can you try there?

@bpasero bpasero modified the milestones: Backlog, August 2021 Aug 6, 2021
@isidorn isidorn self-assigned this Aug 6, 2021
@isidorn
Copy link
Contributor

isidorn commented Aug 6, 2021

Also assigning to me so I try it out on Monday (do not have an iPad with me today).

@TylerLeonhardt
Copy link
Member

Interesting... so when I select some text in the playground, I get the copy and paste buttons and they work as expected (although my shitty Bluetooth keyboard doesn't seem to work... Ctrl/cmd +c/v don't work)
image

However in Codespaces, I select some text and the copy button is not rendered. Paste does work as expected:
image

I'm really not sure why this would be the case... seems unusual...

@bpasero
Copy link
Member

bpasero commented Aug 7, 2021

Oh btw I tried this with a physical external keyboard to the iPad, not the on screen keyboard.

@isidorn
Copy link
Contributor

isidorn commented Aug 10, 2021

I have just tried the following and all works on my iPad, safari, web:

  1. Copy / paste using external mouse
  2. Copy / paste using on screen keyboard
  3. Copy / paste using external keyboard
  4. Copy / paste using touch context menu

As for copy not being present on the screen keyboard, I also did not see that.
@TylerLeonhardt can you maybe create a follow up issue, since this one seems to be about copy /paste on iPad in general which seems to work.

So all seems good. Closing for now, if somebody from the community is also seeing issue with copy/paste please let me know and I can reopen. Thanks!

@isidorn isidorn closed this as completed Aug 10, 2021
@isidorn isidorn added the verification-needed Verification of issue is requested label Aug 23, 2021
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Aug 26, 2021
@TylerLeonhardt
Copy link
Member

Looks like it's all working for me now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality ios-ipados verification-needed Verification of issue is requested verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@bpasero @isidorn @TylerLeonhardt @daybrush @alexdima @rzhao271 and others