Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebooks: Find widget UX #101602

Closed
joaomoreno opened this issue Jul 2, 2020 · 1 comment
Closed

Notebooks: Find widget UX #101602

joaomoreno opened this issue Jul 2, 2020 · 1 comment
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone
July 2020

Comments

@joaomoreno
Copy link
Member

Verifying #99371

Related to the find widget:

  • It doesn't highlight changes as I type
  • When it opens, the entire text inside the find widget should be selected
  • The input background color fails to update as the user switches themes (eg switch from light to black)
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook labels Jul 2, 2020
@roblourens roblourens added this to the July 2020 milestone Jul 2, 2020
@rebornix
Copy link
Member

rebornix commented Jul 9, 2020

It doesn't highlight changes as I type

Fixed via dab68ed

The input background color fails to update as the user switches themes (eg switch from light to black)

Fixed via dab68ed

@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
5 participants
@joaomoreno @roblourens @rebornix @RMacfarlane and others