Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks: cell background makes it look heavier #101710

Closed
bpasero opened this issue Jul 4, 2020 · 7 comments
Closed

Notebooks: cell background makes it look heavier #101710

bpasero opened this issue Jul 4, 2020 · 7 comments
Assignees
Labels
notebook ux User experience issues

Comments

@bpasero
Copy link
Member

bpasero commented Jul 4, 2020

I just looked at how notebooks used to be in stable and prefer it actually over our current designs with regards to the background color on cell. Compare the initial look of a notebook.

Stable
image

Insiders
image

Maybe the cell selection background could be optional for people that want it?

@bpasero bpasero added ux User experience issues notebook labels Jul 4, 2020
@bpasero
Copy link
Member Author

bpasero commented Jul 4, 2020

One particular issue seems to be that we automatically put focus into the first cell each time you open a notebook.

@rebornix rebornix added this to the July 2020 milestone Jul 6, 2020
@rebornix rebornix assigned roblourens and unassigned rebornix Jul 6, 2020
@miguelsolorio
Copy link
Contributor

+1 for not having the first cell auto-focused

@rebornix
Copy link
Member

rebornix commented Jul 6, 2020

If we don't focus the first cell by default, we should make sure arrow keys can focus the cells to make it keyboard accessible.

@roblourens
Copy link
Member

I can focus the list but not the cell

@roblourens
Copy link
Member

I was implementing this but it will only have an affect once per notebook. After that, some cell will probably be focused and then persisted as the focused cell. So I can put it in but does it really make a difference?

@roblourens
Copy link
Member

Unless you were all talking about not focusing any cell by default when opening a notebook, which I think we should definitely do, same as restoring your cursor position in an editor.

@roblourens
Copy link
Member

Hopefully it's better without the shadow at least. I don't want to do anything to get rid of cell focus.

@roblourens roblourens removed this from the July 2020 milestone Jul 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook ux User experience issues
Projects
None yet
Development

No branches or pull requests

4 participants