[Settings Editor] Reset object renderer model state if setting key changes #101806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the same instance of the object widget could be used for different settings, it is necessary to make sure to reset the model state (edit key and selection index) when an instance is reused.
roblourens
approved these changes
Jul 6, 2020
9at8
added a commit
that referenced
this pull request
Jul 6, 2020
As the same instance of the object widget could be used for different settings, it is necessary to make sure to reset the model state (edit key and selection index) when an instance is reused.
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Jul 8, 2020
As the same instance of the object widget could be used for different settings, it is necessary to make sure to reset the model state (edit key and selection index) when an instance is reused.
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Jul 9, 2020
As the same instance of the object widget could be used for different settings, it is necessary to make sure to reset the model state (edit key and selection index) when an instance is reused.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101804
As the same instance of the object widget could be used for different settings, it is necessary to reset the model state (edit key and selection index) when an instance is reused.