Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings Editor] Don't add pairs with empty keys in object settings #101809

Merged
merged 2 commits into from Jul 6, 2020
Merged

[Settings Editor] Don't add pairs with empty keys in object settings #101809

merged 2 commits into from Jul 6, 2020

Conversation

9at8
Copy link
Member

@9at8 9at8 commented Jul 6, 2020

This PR fixes #101805

@9at8 9at8 requested a review from roblourens July 6, 2020 16:51
@9at8 9at8 changed the title [Settings Editor] Don't add empty keys through in object settings [Settings Editor] Don't add pairs with empty keys in object settings Jul 6, 2020
@9at8 9at8 merged commit 701a4f3 into master Jul 6, 2020
@9at8 9at8 deleted the adi/dont-add-empty-pairs branch July 6, 2020 18:42
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this pull request Jul 8, 2020
@9at8 @gjsjohnmurray
Don't add pairs with empty keys in object settings (microsoft#101809)
eab4b9c
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't add items with empty keys in object type settings
2 participants
@9at8 @roblourens