[Settings Editor] Remove debounce on key change in object type settings #101811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #101466 - Removed debounce, so updates happen in a sync fashion and when the user presses tab, it's always moves focus to the correct element. - An additional check in the `shouldUseSuggestion` reduces the number of DOM updates.
roblourens
approved these changes
Jul 6, 2020
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Jul 8, 2020
Fixes: microsoft#101466 - Removed debounce, so updates happen in a sync fashion and when the user presses tab, it's always moves focus to the correct element. - An additional check in the `shouldUseSuggestion` reduces the number of DOM updates.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #101466
user presses tab, it's always moves focus to the correct element.
shouldUseSuggestionreduces the number ofDOM updates.