Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook output renderer picker doesn't use display names #101871

Closed
JacksonKearl opened this issue Jul 7, 2020 · 1 comment
Closed

Notebook output renderer picker doesn't use display names #101871

JacksonKearl opened this issue Jul 7, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone

Comments

@JacksonKearl
Copy link
Contributor

image

    "notebookOutputRenderer": [
      {
        "viewType": "github-issue-static-renderer",
        "displayName": "Static Issue Renderer",
        "mimeTypes": [
          "ms-vscode.github-issue-notebook/github-issue"
        ]
      },
@JacksonKearl
Copy link
Contributor Author

I think at the very least github-issue-static-renderer should be replaced with Static Issue Renderer, and potentially it should be givent higher visual priority over the mimetype. cc @misolori

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Jul 7, 2020
@rebornix rebornix added this to the July 2020 milestone Jul 7, 2020
@rebornix rebornix modified the milestones: July 2020, August 2020 Aug 6, 2020
@connor4312 connor4312 added the verified Verification succeeded label Sep 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@rebornix @connor4312 @JacksonKearl @miguelsolorio and others