Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort extensions by primary languages #102101

Merged
merged 3 commits into from Jul 21, 2020
Merged

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Jul 10, 2020

This PR is for #102032

When associating a mode with an extension, API users of mode.getExtension() take the first returned extension.
The PR makes sure to sort in extension first that come from the 'primary' language contribution. The PR makes the assumption that the 'primary' language contribution is the one that defines the language configuration

@alexdima alexdima merged commit 0e78d70 into master Jul 21, 2020
@alexdima alexdima deleted the aeschli/sortExtByPrimaryLanguage branch July 21, 2020 09:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants