Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug protocol: Please add Variable::settable #10217

Closed
vadimcn opened this issue Aug 5, 2016 · 1 comment
Closed

Debug protocol: Please add Variable::settable #10217

vadimcn opened this issue Aug 5, 2016 · 1 comment
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues

Comments

@vadimcn
Copy link
Contributor

vadimcn commented Aug 5, 2016

  • VSCode Version: 1.4
  • OS Version: All

When a debug adapter reports that is supports setVariable, all leaf variables become editable, but compound objects do not. While a reasonable heuristic, this is not optimal because:

  • primitive values may be not editable if they are "synthetic" i.e. generated by a visualizer.
  • compound objects may be editable, e.g. std::string (which may still want to show individual characters as children, and possibly provide a "raw" view of the implementation as a synthetic child).

I'd suggest adding an explicit "settable" flag into Variable.

@weinand weinand changed the title [debug] Please add Variable::settable Debug protocol: Please add Variable::settable Aug 9, 2016
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Aug 9, 2016
@weinand weinand assigned weinand and unassigned isidorn Aug 9, 2016
@weinand
Copy link
Contributor

weinand commented Aug 19, 2016

This issue was moved to Microsoft/vscode-debugadapter-node#53

@weinand weinand closed this as completed Aug 19, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

3 participants