Source control icon changes if you move it around

[grantborthwick]

Issue Type: Bug

1. Open the terminal
2. Drag the source control icon to the terminal and split it with the terminal
   
3. Drag source control back to the sidebar
   

Expected: it shows the source control icon
Actual: It shows a generic window icon

This also repros on vscode insiders for me with fewer extensions.

Reset Location fixes it, but this is weird!

VS Code version: Code 1.47.0 (d5e9aa0, 2020-07-09T08:02:06.629Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item	Value
CPUs	Intel(R) Xeon(R) CPU E5-1650 v4 @ 3.60GHz (12 x 3592)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	63.92GB (35.32GB free)
Process Argv	--file-uri [path to my workspace].code-workspace
Screen Reader	no
VM	0%

Extensions (25)

Extension	Author (truncated)	Version
sort-imports	ama	6.1.0
xml	Dot	2.5.0
EditorConfig	Edi	0.15.1
vscode-jasmine-test-adapter	hbe	1.6.2
vscode-test-explorer	hbe	2.19.1
vscode-less	mrm	0.6.3
azure-pipelines	ms-	1.170.0
vscode-azurestorage	ms-	0.9.0
vscode-cosmosdb	ms-	0.13.0
remote-containers	ms-	0.128.0
remote-ssh	ms-	0.51.0
remote-ssh-edit	ms-	0.51.0
remote-wsl	ms-	0.44.4
vscode-remote-extensionpack	ms-	0.20.0
azure-account	ms-	0.8.11
hexeditor	ms-	1.1.0
powershell	ms-	2020.6.0
vscode-typescript-tslint-plugin	ms-	1.2.3
vsliveshare	ms-	1.0.2427
debugger-for-chrome	msj	4.12.9
debugger-for-edge	msj	1.0.15
angular-karma-test-explorer	raa	1.2.5
vscode-yaml	red	0.8.0
jstool	sun	1.2006.0
vscodeintellicode	Vis	1.2.9

[grantborthwick]

I've now gotten it into a state where when I reset its location, it goes next to the Problems area at the bottom!

Steps (some of the screenshots reused - that's why the branch changes in the middle):

1. Open the terminal

2. Drag the source control icon to the terminal and split it with the terminal
   

3. Drag it up to make it a new area at the bottom instead of splitting it with the terminal
   

4. Drag source control back to the sidebar
   

5. Right click the "new" source control icon and select Reset Location
   

Expected: It fixes the icon and puts it in the right place
Actual: It moves it back to the bottom!

Resetting it again here moves it to the correct place. I also can repro this with the search panel except without the icon change.

[grantborthwick]

I also observe that when the source control panel has the different icon or is on the bottom panel, Ctrl + Shift + G doesn't switch to it anymore.

[joaomoreno]

@sbatten Advice, and maybe candidate?

[joaomoreno]

Fixed the icon and keyboard shortcut. Moved the the reset issue to #102396