Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Cursor animations tweak #10277

Closed
traavnik opened this issue Aug 7, 2016 · 2 comments
Closed

[suggestion] Cursor animations tweak #10277

traavnik opened this issue Aug 7, 2016 · 2 comments
Assignees
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality
Milestone

Comments

@traavnik
Copy link

traavnik commented Aug 7, 2016

I like new cursors in v1.4.0 (#7923, #8153), but I don't like how they glitch whenever their position changes.
I would suggest swapping animation direction to make transition more fluid.

Current expanding animation:
(notice how cursor disappears in a single frame when animation gets loaded)
cursorbefore

@keyframes cursor-expand {
    0%,
    20% {
        transform: scaleY(0);
    }
    80%,
    100% {
        transform: scaleY(1);
    }
}

Inverted animation:
cursorafter

@keyframes cursor-expand {
    0%,
    20% {
        transform: scaleY(1);
    }
    80%,
    100% {
        transform: scaleY(0);
    }
}

The glitch is also visible with other cursor options that use soft transitions.

I've also noticed some delay before cursor animations is loaded. I'm not sure if that's by design and what exactly causes it (can't read .ts that well yet, let alone compile stuff to try it out). I would assume it's intentional delay that was originally used for blinking cursor. I think that new cursors could be used without delay, if every animation got inverted.

Edit: It might be better to leave delay as is in order to avoid distracting animations while typing and moving cursor. In such case, blinking animation shouldn't be inverted, only the ones with soft transitions should.

@alexdima
Copy link
Member

alexdima commented Aug 8, 2016

I am open to tweaking the animations. PR welcome. fyi @kisstkondoros

@alexdima alexdima added this to the Backlog milestone Aug 8, 2016
@alexdima alexdima added editor-core-view feature-request Request for new features or functionality labels Aug 9, 2016
@alexdima alexdima modified the milestones: August 2016, Backlog Aug 30, 2016
@alexdima
Copy link
Member

PR #11093 addressed this. Thanks to @sprinkle131313

@alexdima alexdima added editor-core Editor basic functionality and removed editor-core-view labels Aug 30, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants