Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat all files with git{config,attributes,modules}/editorconfig extensions as properties files #103326

Merged
merged 1 commit into from Jul 30, 2020

Conversation

NotWearingPants
Copy link
Contributor

This PR fixes #103042 (again), as I found more occurrences of the issue -
files with the extensions .gitconfig, .gitattributes, .gitmodules, .editorconfig are not being considered of type Properties,
unless they match that exact filename, with nothing before the dot.

How to test:
Create and open files named john.gitconfig, server.gitattributes, client.gitmodules, windows.editorconfig.
The language mode for them should be set to Properties.

@joaomoreno joaomoreno added this to the July 2020 milestone Jul 30, 2020
@joaomoreno joaomoreno merged commit 211fe2f into microsoft:master Jul 30, 2020
@joaomoreno
Copy link
Member

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants