Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing portion in webview web integration test #103419

Closed
alexdima opened this issue Jul 27, 2020 · 2 comments
Closed

Failing portion in webview web integration test #103419

alexdima opened this issue Jul 27, 2020 · 2 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug integration-test-failure web Issues related to running VSCode in the web

Comments

@alexdima
Copy link
Member

I commented it out for now via 88e6416

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=83065&view=logs&j=a5e52b91-c83f-5429-4a68-c246fc63a4f7&t=087c9a82-9b9b-5b5f-17f2-a070cb4808e3
@mjbvz mjbvz closed this as completed in 7493065 Jul 28, 2020
@alexdima
Copy link
Member Author

alexdima commented Jul 28, 2020 •
edited

@mjbvz I'm sorry I had to comment this out and partially revert your change via f485d75 because today's build failed again in this area https://dev.azure.com/monacotools/Monaco/_build/results?buildId=83112&view=logs&j=800c766b-cf7f-545c-6b0a-ae5b31f2fdcf&t=51b4207b-308f-5f00-05c4-35120a101a46&l=274

I have tried to troubleshoot the problem on Windows web integration tests, and here is what I saw as input and output to that function:

input: file:///c%3A/Alex/src/vscode/extensions/vscode-api-tests/testWorkspace/sub/image.png
output: vscode-remote://localhost:9888/vscode-resource?%7B%22requestResourcePath%22%3A%22%2Fc%253A%2FAlex%2Fsrc%2Fvscode%2Fextensions%2Fvscode-api-tests%2FtestWorkspace%2Fsub%2Fimage.png%22%7D

This looks like a really tricky problem. Please attempt to fix it via a PR and by running a full build before merging to avoid breaking the daily insiders a 3rd time ❤️.

@alexdima alexdima reopened this Jul 28, 2020
@bpasero bpasero added the web Issues related to running VSCode in the web label Sep 3, 2020
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Sep 22, 2020
@joaomoreno joaomoreno added this to the January 2021 milestone Jan 7, 2021
@mjbvz mjbvz modified the milestones: January 2021, February 2021 Jan 28, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Jan 28, 2021

Closing this in favor of #113769

@mjbvz mjbvz closed this as completed Jan 28, 2021
@mjbvz mjbvz removed this from the February 2021 milestone Jan 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug integration-test-failure web Issues related to running VSCode in the web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@joaomoreno @bpasero @alexdima @mjbvz and others