Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extensions to contribute toggle-type command actions to menus #103557

Closed
gjsjohnmurray opened this issue Jul 29, 2020 · 4 comments
Closed

Allow extensions to contribute toggle-type command actions to menus #103557

gjsjohnmurray opened this issue Jul 29, 2020 · 4 comments
Assignees
@jrieken @sbatten
Labels
feature-request Request for new features or functionality menus Menu items and widget issues
Milestone
Backlog Candidates

Comments

@gjsjohnmurray
Copy link
Contributor

Issue Type: Feature Request

Since #92284 there seems to have been support for toggle-type command actions, but I haven't found any way an extension can make use of this.

Related to this, since #77481 there has been a background color for active toggle buttons.

It would be useful for an extension to contribute, say, a toggle-type menu item to the inline group of the view/item/context menu, specifying a single codicon as its icon, and relying on VS Code to display the codicon on the button with or without inputOption.activeBackground color depending upon its toggle-state.

VS Code version: Code - Insiders 1.48.0-insider (15e798e, 2020-07-28T10:39:18.007Z)
OS version: Windows_NT x64 10.0.18363
@sbatten
Copy link
Member

sbatten commented Jul 30, 2020

adding @joaomoreno and @jrieken since they have been on menu api

@sbatten sbatten added the feature-request Request for new features or functionality label Jul 30, 2020
@joaomoreno joaomoreno removed their assignment Aug 3, 2020
@jrieken jrieken added the menus Menu items and widget issues label Aug 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@sbatten sbatten

Labels
feature-request Request for new features or functionality menus Menu items and widget issues
Projects
None yet
Milestone
Backlog Candidates
Development

No branches or pull requests
5 participants
@joaomoreno @jrieken @sbatten @gjsjohnmurray and others