Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity Test Settings Sync #103613

Closed
3 tasks done
sandy081 opened this issue Jul 30, 2020 · 5 comments
Closed
3 tasks done

Sanity Test Settings Sync #103613

sandy081 opened this issue Jul 30, 2020 · 5 comments

Comments

@sandy081
Copy link
Member

sandy081 commented Jul 30, 2020

Complexity: 5

Create Issue


Set Up

You can use two insiders opened with different user data directory (--user-data-dir) and extension directory (--extensions-dir) for test syncing across machines.

Testing

We are planning to enable Settings Sync for stable users in this release. So, I would ask the assignees to do an exploratory end to end testing of following settings sync features.

  • Make sure you get a preview confirmation dialog when you turn on sync for the very fist time. Even though we are enabling for stable users this feature will be still in preview mode.
  • Make sure Settings Sync term is used in the product to represent this feature
  • Test settings, keybindings, snippets, extensions and UI state are syncing across devices flawlessly.
    • Test machine and machine-overridable scoped settings are ignored by default. These are typically settings that has local paths as values.
    • Test enablement state of extensions is synced
    • Test advanced features like ignoring settings, extensions and syncing keybindings across platforms
    • Test you can able to handle and resolve conflicts if they occur
  • Make sure you can track and monitor sync activity and discover all necessary sync features.
    • Test Sync Activity & Machines view using the command Settings Sync: Show Synced Data
    • Test the actions available in these views (Restoring, editing machine name & turning off sync on a machine)
  • Test turning off Settings Sync either on current machine or on all machines.

Authors: @sandy081 @Tyriar

@connor4312
Copy link
Member

Test machine and machine-overridable scoped settings are ignored by default. These are typically settings that has local paths as values.

I'm not sure what these are, how do I find out which settings are machine/machine-overridable?

@sandy081
Copy link
Member Author

sandy081 commented Aug 5, 2020

@JacksonKearl Sorry for not being clear about machine scoped settings. These settings are those whose scope is defined as machine or machine-overridable while being registered. UI does not represent it. Here are some machine scope settings:

  • git.path
  • typescript.npm
  • typescript.tsserver.pluginPaths
  • php.validate.executablePath

@JacksonKearl
Copy link
Contributor

I think you meant @connor4312 but good to know 🙂

@sandy081
Copy link
Member Author

sandy081 commented Aug 5, 2020

Oops sorry.

@weinand
Copy link
Contributor

weinand commented Aug 5, 2020

After testing Settings Sync for a day, I must say that it works "smooth as silk". Great job!

@weinand weinand removed their assignment Aug 5, 2020
@weinand weinand closed this as completed Aug 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants