Change includePackageJsonAutoImports options #103732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
reviewed
Aug 3, 2020
| "typescript.preferences.includePackageJsonAutoImports.none": "Disable package.json dependency processing.", | ||
| "typescript.preferences.includePackageJsonAutoImports": "Enable/disable searching `package.json` dependencies for available auto imports.", | ||
| "typescript.preferences.includePackageJsonAutoImports.auto": "Search dependencies based on estimated performance impact.", | ||
| "typescript.preferences.includePackageJsonAutoImports.on": "Always search dependencies.", |
There was a problem hiding this comment.
Just a quick question, will this also search dev dependencies?
There was a problem hiding this comment.
No, I decided to remove that functionality unless/until there’s high demand for it. Since lots of devDependencies go unimported and creating auto import providers that contain lots of dependencies have an associated startup performance penalty, the setting was a perf trap door without enough room to explain all the considerations of enabling it.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart of microsoft/TypeScript#39855. Related: #103037
cc: @mattbierner