Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace innerHTML with innerText when assigning non-html string #103841

Merged
merged 4 commits into from Aug 12, 2020
Merged

Replace innerHTML with innerText when assigning non-html string #103841

merged 4 commits into from Aug 12, 2020

Conversation

annkamsk
Copy link
Contributor

@annkamsk annkamsk commented Aug 3, 2020

This PR fixes #103700
It replaces assignments of '', ' ' or ' ' to .innerHTML with assignments to .innerText

@ghost
Copy link

ghost commented Aug 3, 2020 •
edited by ghost

CLA assistant check
All CLA requirements met.

@jrieken jrieken self-assigned this Aug 10, 2020
@jrieken jrieken added this to the August 2020 milestone Aug 10, 2020
@jrieken jrieken added the debt Code quality issues label Aug 12, 2020
@jrieken jrieken self-requested a review August 12, 2020 09:47
@jrieken jrieken merged commit a1b6553 into microsoft:master Aug 12, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

Assignees

@jrieken jrieken

Labels
debt Code quality issues
Projects
None yet
Milestone
August 2020
Development

Successfully merging this pull request may close these issues.

Trusted Types compatibility: replace innerHTML with innerText when assigning non-html string
3 participants
@annkamsk @jrieken @aeschli