Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to ensure TS 4.0-RC and forward use '--serverMode'. #104123

Merged
merged 1 commit into from Aug 5, 2020
Merged

Add check to ensure TS 4.0-RC and forward use '--serverMode'. #104123

merged 1 commit into from Aug 5, 2020

Conversation

DanielRosenwasser
Copy link
Member

The semver thing is temporary. I think that in the future, you should be able to just make it 4.0.0 and use gte.

Also, haven't been able to test it out, I did the work in a codespace.

CC @mjbvz

@DanielRosenwasser
Copy link
Member Author

@sheetalkamat @amcasey @RyanCavanaugh

@mjbvz mjbvz added this to the July 2020 milestone Aug 5, 2020
@mjbvz mjbvz merged commit 54a38a2 into microsoft:master Aug 5, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Aug 5, 2020

Thanks @DanielRosenwasser! I'll test this locally to make sure it does the correct thing

@DanielRosenwasser DanielRosenwasser deleted the serverModeTS branch August 5, 2020 22:27
@DanielRosenwasser
Copy link
Member Author

My first PR in VS Code! 🎉

@mjbvz mjbvz mentioned this pull request Aug 11, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanielRosenwasser @mjbvz