Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Split cell" action shows up for every cell toolbar #104128

Closed
roblourens opened this issue Aug 5, 2020 · 0 comments
Closed

"Split cell" action shows up for every cell toolbar #104128

roblourens opened this issue Aug 5, 2020 · 0 comments
Assignees
@roblourens @rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone
August 2020

Comments

@roblourens
Copy link
Member

  • Have two cells, cell A has the editor focused, so the split cell action is visible in the toolbar
  • Hover cell B, it also shows the split cell action in the toolbar, incorrectly

This depends on inputFocus which gets set in the global context key service. Need a new context key for editor state
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook labels Aug 5, 2020
@rebornix rebornix added this to the August 2020 milestone Aug 5, 2020
@roblourens roblourens mentioned this issue Sep 1, 2020
Closed
@connor4312 connor4312 added the verified Verification succeeded label Sep 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
4 participants
@roblourens @rebornix @connor4312 and others