Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automationShell.osx doesnt work when set in workspaceFolder #104380

Closed
jahan01 opened this issue Aug 10, 2020 · 4 comments
Closed

automationShell.osx doesnt work when set in workspaceFolder #104380

jahan01 opened this issue Aug 10, 2020 · 4 comments
Assignees
Labels
*as-designed Described behavior is as designed

Comments

@jahan01
Copy link

jahan01 commented Aug 10, 2020

  • VSCode Version: 1.47 - Tested with insider version as well
  • OS Version: Mac 10.15

Steps to Reproduce:

  1. Open a vscode workspace
  2. Set the following in workspace settings ( .vscode/settings.json)
"terminal.integrated.automationShell.osx": "/bin/bash"
  1. Launch a build task (tested with default tsc build task without anything in tasks.json), it still runs in the default shell.
  2. Keep the same setting in global user settings.
  3. Launch a build task, opens in the configured shell correctly.

Does this issue occur when all extensions are disabled?: Yes

@alexr00
Copy link
Member

alexr00 commented Aug 12, 2020

This is intentional, we don't want random repositories you clone to set your shell without your knowledge. To enable the behavior you want, use the command Terminal: Manage Workspace Shell Permissions.

@alexr00 alexr00 closed this as completed Aug 12, 2020
@alexr00 alexr00 added the *as-designed Described behavior is as designed label Aug 12, 2020
@jahan01
Copy link
Author

jahan01 commented Aug 12, 2020

thanks, it works.. setting description or docs doesn't provide any information on this. Perhaps a note in the settings description, describing this behaviour would have avoided me creating this ticket and thus would have saved some your time.

@alexr00
Copy link
Member

alexr00 commented Aug 12, 2020

@Tyriar FYI on above comment

@Tyriar
Copy link
Member

Tyriar commented Aug 12, 2020

We will likely be revisiting workspace permissions UX soon 👍

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

3 participants