Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook editor widget is reinstantiated when dragging between notebook between groups #104535

Closed
roblourens opened this issue Aug 13, 2020 · 2 comments
Closed

Notebook editor widget is reinstantiated when dragging between notebook between groups #104535

roblourens opened this issue Aug 13, 2020 · 2 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone
August 2020

Comments

@roblourens
Copy link
Member

  • Open a github issues notebook and execute a cell
  • Drag it from group 1 to group 2
  • You can tell that the notebook webview is recreated by the way the output blinks and loses any transient state like selections, it should be reused in the new group
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook labels Aug 13, 2020
@roblourens roblourens added this to the August 2020 milestone Aug 13, 2020
@roblourens roblourens self-assigned this Aug 13, 2020
@roblourens
Copy link
Member Author

@bpasero please review, also @rebornix this changed slightly since you saw it

@bpasero
Copy link
Member

bpasero commented Aug 13, 2020

Change LGTM, thanks for ping.

@connor4312 connor4312 added the verified Verification succeeded label Sep 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
4 participants
@roblourens @bpasero @connor4312 and others