Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "(approximate)" to TS partial mode hovers / IntelliSense #104859

Closed
mjbvz opened this issue Aug 17, 2020 · 3 comments
Closed

Add "(approximate)" to TS partial mode hovers / IntelliSense #104859

mjbvz opened this issue Aug 17, 2020 · 3 comments
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2020

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Aug 17, 2020

Follow up on microsoft/TypeScript#40061

/cc @DanielRosenwasser
@mjbvz mjbvz added feature-request Request for new features or functionality typescript Typescript support issues labels Aug 17, 2020
@mjbvz mjbvz added this to the August 2020 milestone Aug 17, 2020
@mjbvz mjbvz self-assigned this Aug 17, 2020
@mjbvz mjbvz changed the title Add "(approximate)" to TS partial mode completions Add "(approximate)" to TS partial mode hovers / IntelliSense Aug 17, 2020
@mjbvz mjbvz closed this as completed in 650f768 Aug 18, 2020
@mjbvz mjbvz added verification-needed Verification of issue is requested and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 18, 2020
@mjbvz
Copy link
Contributor Author

mjbvz commented Aug 18, 2020

Here's what this now looks like:

Screen Shot 2020-08-17 at 5 49 03 PM

For verification:

  1. Open the VS Code workspace
  2. Open a TS file
  3. While the status bar loading indicator is showing, hover over a variable
    • Confirm (loading...) is shown in the hover
  4. Now wait for TS to finish loading.
  5. Hover again
    • Confirm that there is no longer any (loading...) indicator

Also test hover in the serverless cases. This should never display (loading...) since we will never load the full server

@DanielRosenwasser
Copy link
Member

Looks good! I'm a fan and agree with the serverless mode behavior.

@jrieken jrieken added the verified Verification succeeded label Sep 1, 2020
@jrieken
Copy link
Member

jrieken commented Sep 1, 2020

Verified but I would have preferred to see some pretty codicon, like the loading codicon

@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
4 participants
@DanielRosenwasser @jrieken @mjbvz and others