Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerName on SymbolInformation is unexpectedly stripped of data in WorkspaceSymbolProvider results #10504

Closed
DanTup opened this issue Aug 13, 2016 · 3 comments
Assignees

Comments

@DanTup
Copy link
Contributor

DanTup commented Aug 13, 2016

  • VSCode Version: 1.4
  • OS Version: Windows 10

If you set containerName to null when returning symbol results, Code displays the full file path:

Full path displayed

However this isn't very pretty for imported Dart packages so we want to tweak it. However, if you set a value for containerName then everything up to the last dot gets stripped:

containerName: "c:\test\danny.dart"

Stripped path

This doesn't seem very logical. If it's valid for Code to display the name when a containerName is not provided, it should be valid for us to provide a similar value (for example, we might wish to display just a relevant part of the tree, thing\file.dart which currently also just displays dart).

@devoncarew
Copy link

devoncarew commented Aug 14, 2016

I can repro this on the latest stable release, but do not see the issue on the latest VSCode Insider's release.

Nevermind - re-testing and I do see this w/ the insiders build.

@aeschli aeschli assigned jrieken and unassigned aeschli Aug 15, 2016
@jrieken
Copy link
Member

jrieken commented Aug 15, 2016

I have cleaned that up 2 weeks ago (36a2a04#diff-00712023721c685fc8697e7bc7e85cb6). No clue why had those funny rules...

@jrieken jrieken closed this as completed Aug 15, 2016
@DanTup
Copy link
Contributor Author

DanTup commented Aug 15, 2016

Aha, that's why I couldn't find the code that was doing this, it's since gone!

Thanks (again!)

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants