Terminal: Support linking local file paths containing '+' #105108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the + character was excluded so file paths like: `some/folder/Foo+Extension.swift` and `some/folder/Object+Category.m` would not link properly in the terminal
|
|
|
Friendly ping |
|
Sorry about the delay, I'm trying to catch up on my PRs next week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the + character was excluded so file paths like:
some/folder/Foo+Extension.swiftandsome/folder/Object+Category.mwould not link properly in the terminal
This PR fixes #92386
Test:
cd /tmp && touch Foo.h && touch Foo+Bar.hecho /tmp/Foo.h /tmp/Foo+Bar.hCmd(on macOS) and mouse over the two listing name, now both will be clickable.