Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid lookups to api.npms.io for invalid package names #105334

Closed
aeschli opened this issue Aug 25, 2020 · 3 comments
Closed

avoid lookups to api.npms.io for invalid package names #105334

aeschli opened this issue Aug 25, 2020 · 3 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug json JSON support issues perf verified Verification succeeded
Milestone
July 2020 Recovery 2

Comments

@aeschli
Copy link
Contributor

aeschli commented Aug 25, 2020 •
edited

  • open a package.json
  • start editing a package dependency with the mouse over the dependency
  • accesses are made to npm.exe or api.npms.io to look up the description
@aeschli aeschli self-assigned this Aug 25, 2020
@aeschli aeschli changed the title avoid unnecessary accesses to api.npms.io avoid lookups to api.npms.io for invalid package names Aug 25, 2020
@aeschli aeschli added this to the July 2020 Recovery 2 milestone Aug 25, 2020
@aeschli aeschli added bug Issue identified by VS Code Team member as probable bug json JSON support issues labels Aug 25, 2020
@aeschli
Copy link
Contributor Author

aeschli commented Aug 25, 2020

Fixed by 88664e2
and ed15973

@aeschli aeschli added the perf label Aug 25, 2020
@isidorn
Copy link
Contributor

isidorn commented Aug 25, 2020

Since this is fixed closing

@isidorn isidorn closed this as completed Aug 25, 2020
@aeschli
Copy link
Contributor Author

aeschli commented Aug 25, 2020 •
edited

To verify:

  • have a machine with no npm installed
  • use the network view to verify that api.npms.io is not accessed if you have package names that have characters not valid in URLs are empty or start/end with whitespaces

@chrmarti chrmarti added the verified Verification succeeded label Aug 25, 2020
@justinsteven justinsteven mentioned this issue Oct 2, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug json JSON support issues perf verified Verification succeeded
Projects
None yet
Milestone
July 2020 Recovery 2
Development

No branches or pull requests
3 participants
@isidorn @aeschli @chrmarti