Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set HTMLElement's content by providing it as a child, not by .innerHTML #105506

Merged
merged 1 commit into from Aug 28, 2020
Merged

Set HTMLElement's content by providing it as a child, not by .innerHTML #105506

merged 1 commit into from Aug 28, 2020

Conversation

annkamsk
Copy link
Contributor

This PR fixes #105505
It replaces: dom.append(parent, $(‘span’)).innerHTML = text with dom.append(parent, $(‘span’, {}, text)).

@aeschli aeschli assigned chrmarti and unassigned aeschli Aug 28, 2020
@jrieken jrieken requested a review from chrmarti August 28, 2020 08:36
@jrieken jrieken added the engineering VS Code - Build / issue tracking / etc. label Aug 28, 2020
@chrmarti chrmarti merged commit 44700f8 into microsoft:master Aug 28, 2020
@chrmarti chrmarti added this to the August 2020 milestone Aug 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrmarti chrmarti Awaiting requested review from chrmarti

Assignees

@chrmarti chrmarti

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
August 2020
4 participants
@annkamsk @jrieken @aeschli @chrmarti