Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use extensionUri and joinPath instead of asAbsolutePath #105585

Merged
merged 2 commits into from Aug 31, 2020
Merged

Use extensionUri and joinPath instead of asAbsolutePath #105585

merged 2 commits into from Aug 31, 2020

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Aug 28, 2020 •
edited

This PR fixes #105277

The PR adopts browser parts to construct worker urls using the proper API. Today, this only works because of this (which we should nuke)

vscode/src/vs/workbench/api/common/extHostExtensionService.ts

Lines 388 to 395 in df5d0e5

asAbsolutePath(relativePath: string) {
if (platform.isWeb) {
// web worker
return URI.joinPath(extensionDescription.extensionLocation, relativePath).toString();
} else {
return path.join(extensionDescription.extensionLocation.fsPath, relativePath);
}
},

@jrieken jrieken requested review from aeschli and mjbvz August 28, 2020 12:59
@jrieken jrieken added this to the August 2020 milestone Aug 28, 2020
@jrieken jrieken self-assigned this Aug 28, 2020
@jrieken jrieken merged commit f1e7a02 into master Aug 31, 2020
@jrieken jrieken deleted the joh/useExtUri branch August 31, 2020 07:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschli aeschli aeschli approved these changes

@mjbvz mjbvz mjbvz approved these changes

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
August 2020
Development

Successfully merging this pull request may close these issues.

asAbsolutePath-usage in web
3 participants
@jrieken @aeschli @mjbvz