New Search Editor focuses results instead of query input when seeded (use focusResults: false by default)

[benalavi]

• VSCode Version: 1.48.1
• OS Version: Mac OS 10.14.6

Steps to Reproduce:

1. Select text
2. Open New Search Editor (either via command pallet or key binding)
3. Cursor jumps to first line of results (summary info, i.e. 1 result - 1 file)

Does this issue occur when all extensions are disabled?: Yes/No

Yes

---

TL;DR: "focusResults": false might be a more expected default for Search Editor: New Search Editor

Expected Behavior: I expected that upon opening a Search Editor: New Search Editor the query term would be highlighted and the focus would remain on the query term. In the below screenshot I would expect "Foo" is highlighted and the query bar has focus.

Note that when there is no highlighted text this is the behavior when opening a New Search Editor:

I expected this behavior because it is the same behavior as the other two search cases:

Find:

...and Search: Find in Files

This often becomes an annoyance for me because of the following use case:

• Have Search Editor: New Search Editor bound to Cmd+Shift+F
• Working in a file, happen to have some highlighted text
• Realize I might need to make some change in another file, open a New Search Editor w/ Cmd+Shift+F to find out
• Highlighted text is searched for automatically
• Start typing/paste what was on my clipboard thinking it will override the search term
• End up inadvertently editing the search results
• Press Esc to get back to the search query
• Try typing/pasting again
• Eventually try to close the New Search Editor and am modally prompted to save it because I inadvertently edited it earlier
• Close the modal w/ mouse or Cmd+D (which I learned because of this, silver linings)

I believe this might be relatively recent behavior that was added w/ #95582 and/or #97823

Based on those I found that I could get the functionality I expected by setting "focusResults": false in keybindings.json, i.e:

    {
        "key": "shift+cmd+f",
        "command": "search.action.openNewEditor",
        "args": {
            "focusResults": false
        }
    }

...at which point I considered just not bothering posting an issue 😅 But because the behavior seems to be inconsistent I think "focusResults": false might be a more sensible default for search.action.openNewEditor.

Complete conjecture but I imagine the current behavior might have led to issues like: #105034 as my first instinct was to wonder why the search results were editable at all.

[JacksonKearl]

I think this makes sense, to be consistent with the other search widgets.