Preserve all new lines in MarkdownString appendText #105732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks good. Thanks for the making the fix! If the fix is not urgent though, I suggest we push it to September though in case there are unforeseen consequences |
mjbvz
approved these changes
Aug 31, 2020
jrieken
approved these changes
Sep 1, 2020
|
I discovered this bug when I was fixing another bug in custom tree hovers. This month, I switched all custom tree view hovers to use the new hover service which uses markdown instead of text like the old builtin tooltip does. This change is needed to not break multiline tooltips that extension authors have in their custom tree views. If we don't want to take this change, then I will need to revert the change to use the hover service or copy |
|
Lets take the risk |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using appendText, I noticed that only the first newline is getting preserved.