Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity bar: visibility of things is not synced #105793

Closed
bpasero opened this issue Sep 1, 2020 · 3 comments
Closed

Activity bar: visibility of things is not synced #105793

bpasero opened this issue Sep 1, 2020 · 3 comments
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Sep 1, 2020

For example, I hide the accounts icon but this state is not synced. Maybe this was not marked for syncing? Should we maybe do a pass over new keys that were added that need to be marked as sync?

@bpasero bpasero added the layout General VS Code workbench layout issues label Sep 1, 2020
@sandy081 sandy081 removed their assignment Sep 1, 2020
@sandy081
Copy link
Member

sandy081 commented Sep 1, 2020

Yes, This key is not registered to sync.

@bpasero I think we need a better strategy. Idea:

  • Introduce machine storage scope and consider those stored in global scope for sync?

@bpasero
Copy link
Member Author

bpasero commented Sep 1, 2020

@sandy081 or alternatively we could flip it around and say that a key needs to be explicitly excluded if you don't want to sync it. I am not sure I would tie storage service and storage syncing together. Ideally the storage sync layer would observe what keys are used globally and then react to it.

@bpasero bpasero self-assigned this Sep 1, 2020
@bpasero bpasero added this to the August 2020 milestone Sep 1, 2020
@bpasero bpasero closed this as completed in fee0167 Sep 1, 2020
@bpasero
Copy link
Member Author

bpasero commented Sep 1, 2020

I pushed fee0167 as a fix.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @RMacfarlane @sandy081 and others