Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screencast: enable validation and color picker for screencastMode.mouseIndicatorColor #105811

Closed
aeschli opened this issue Sep 1, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders screencast-mode verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Sep 1, 2020

Testing #105721

  • open the JSON settings, add "screencastMode.mouseIndicatorColor": "#ff00ff"
    -> there's no color decorator or color picker as for other colors
  • change the value to ff00ff: No error shown

You all get that by adding "format": "color-hex" to the setting configuration. But css color names (red, ...) are not supported by that.
As other color settings don't support the css names either, I suggest to only support hex for consistency reasons.

@aeschli aeschli assigned aeschli and lszomoru and unassigned aeschli Sep 1, 2020
@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug screencast-mode labels Sep 1, 2020
@lszomoru lszomoru added this to the August 2020 milestone Sep 1, 2020
@aeschli
Copy link
Contributor Author

aeschli commented Sep 1, 2020

Excellent. Now you can use Color.fromHex to read (and verify) the settings value and color.toString to get the CSS string. Right now 'blue' would still work

@lszomoru lszomoru reopened this Sep 2, 2020
@aeschli aeschli added the verified Verification succeeded label Sep 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders screencast-mode verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants
@lszomoru @aeschli and others